Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saha #860

Merged
merged 99 commits into from
Jul 11, 2020
Merged

Saha #860

merged 99 commits into from
Jul 11, 2020

Conversation

KhalilBryant
Copy link
Contributor

@KhalilBryant KhalilBryant commented Jun 23, 2020 •
edited
Loading

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

KhalilBryant and others added 30 commits May 21, 2020 19:17
@KhalilBryant
Create 815.feature.rst
4cd2127
@KhalilBryant
Update 815.feature.rst
3692842
@KhalilBryant
Add Reynolds_number to the PlasmaPy Formulary
7c79701
@KhalilBryant
Add Reynolds_number to the Formulary (PlasmaPy#815)
5a3302c
@KhalilBryant
Add Reynolds_number to the Formulary
0743f44 
(#PlasmaPy 815)
@KhalilBryant
Add Reynolds_number to the Formulary
7aa5985
@KhalilBryant
Delete 815.feature.rst
2bede64
@KhalilBryant
Merge branch 'master_from_plasmapy' into Bohm-diffusion-coefficient
bbc05ff
@KhalilBryant
update plasmapy/formulary/parameters.py
56d15c0
@KhalilBryant
update plasmapy/formulary/tests/test_parameters.py
b672cf6
@KhalilBryant
update plasmapy/formulary/parameters.py
bfeb49a
@KhalilBryant
Merge branch 'master_from_plasmapy'
05f7cb6
@KhalilBryant
update plasmapy/formulary/parameters.py
e5daea6
@KhalilBryant
Add Bohm_diffusion to the formulary
bc0ab7e
@KhalilBryant
update plasmapy/formulary/parameters.py
4d96d90
@KhalilBryant
update plasmapy/formulary/parameters.py
4bb3181
@KhalilBryant
Merge remote-tracking branch 'origin/Bohm-diffusion-coefficient' into…
84b105f 
… Bohm-diffusion-coefficient
@KhalilBryant
update plasmapy/formulary/parameters.py
29d89fb
@KhalilBryant @StanczakDominik
Update plasmapy/formulary/tests/test_parameters.py
a3e87e4 
Co-authored-by: Dominik Stańczak <[email protected]>
@KhalilBryant @StanczakDominik
Update plasmapy/formulary/parameters.py
623300f 
Co-authored-by: Dominik Stańczak <[email protected]>
@KhalilBryant
update plasmapy/formulary/parameters.py
334b5bb
@KhalilBryant
update plasmapy/formulary/parameters.py
8c91ae2
@KhalilBryant
update plasmapy/formulary/parameters.py
741b913
@KhalilBryant
update plasmapy/formulary/parameters.py
7ad80e8
@StanczakDominik
Restore lower_hybrid_frequency
cab9973 
Sorry, I made a typo in my suggestion ("requency") and I guess that made you remove it later on :( This fixes it.
@StanczakDominik
One more typo
95d7a43
@KhalilBryant
Merge remote-tracking branch 'origin/Bohm-diffusion-coefficient' into…
78daa71 
… Bohm-diffusion-coefficient

# Conflicts:
#	plasmapy/formulary/parameters.py
@KhalilBryant
update plasmapy/formulary/parameters.py
f47934c
@KhalilBryant
update plasmapy/formulary/parameters.py
496878f
@KhalilBryant
update plasmapy/formulary/parameters.py
7edcbd3
rocco8773
rocco8773 requested changes Jul 10, 2020
View reviewed changes
Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use DOI links since they are longer lasting than normal web links.

plasmapy/formulary/ionization.py Show resolved Hide resolved
plasmapy/formulary/ionization.py Outdated Show resolved Hide resolved
plasmapy/formulary/ionization.py Outdated Show resolved Hide resolved
plasmapy/formulary/ionization.py Show resolved Hide resolved
rocco8773
rocco8773 approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@rocco8773 rocco8773 merged commit 72443f3 into PlasmaPy:master Jul 11, 2020
@rocco8773 rocco8773 mentioned this pull request Jul 11, 2020
Closed
26 tasks
@KhalilBryant KhalilBryant deleted the saha branch July 11, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocco8773 rocco8773 rocco8773 approved these changes

@StanczakDominik StanczakDominik StanczakDominik approved these changes

@namurphy namurphy Awaiting requested review from namurphy

Assignees

@KhalilBryant KhalilBryant

Labels
plasmapy.formulary Related to the plasmapy.formulary subpackage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhalilBryant @StanczakDominik @rocco8773