Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionization #851

Merged
merged 55 commits into from
Jun 23, 2020
Merged

Ionization #851

merged 55 commits into from
Jun 23, 2020

Conversation

KhalilBryant
Copy link
Contributor

@KhalilBryant KhalilBryant commented Jun 10, 2020

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

This adds the ionization module to the formulary as well as Z_bal from the Saha equation

KhalilBryant and others added 30 commits May 21, 2020 19:17
Sorry, I made a typo in my suggestion ("requency") and I guess that made you remove it later on :( This fixes it.
… Bohm-diffusion-coefficient

# Conflicts:
#	plasmapy/formulary/parameters.py
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #851 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
+ Coverage   95.94%   95.95%   +0.01%     
==========================================
  Files          56       57       +1     
  Lines        5126     5140      +14     
==========================================
+ Hits         4918     4932      +14     
  Misses        208      208              
Impacted Files Coverage Δ
plasmapy/formulary/ionization.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e358f...8057611. Read the comment docs.

plasmapy/formulary/dimensionless.py Outdated Show resolved Hide resolved
plasmapy/formulary/ionization.py Outdated Show resolved Hide resolved
plasmapy/formulary/ionization.py Show resolved Hide resolved
plasmapy/formulary/ionization.py Show resolved Hide resolved
@StanczakDominik
Copy link
Member

Remember to commit/push the alias change from today, and this will probably be a quick merge! :)

@KhalilBryant KhalilBryant marked this pull request as ready for review June 18, 2020 17:39
Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @KhalilBryant :)

@StanczakDominik StanczakDominik merged commit 983c2f8 into PlasmaPy:master Jun 23, 2020
@rocco8773 rocco8773 added the plasmapy.formulary Related to the plasmapy.formulary subpackage label Jul 9, 2020
@rocco8773
Copy link
Member

touches issue #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.formulary Related to the plasmapy.formulary subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants