Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit github action #845

Merged
merged 6 commits into from
Jun 8, 2020

Conversation

StanczakDominik
Copy link
Member

@StanczakDominik StanczakDominik commented Jun 8, 2020

Uses template as per https://github.com/pre-commit/action

Closes #839

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #845 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          56       56           
  Lines        5127     5127           
=======================================
  Hits         4916     4916           
  Misses        211      211           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71475a...89d1fcd. Read the comment docs.

Flake8 has valuable fixes, but it makes committing too slow and I find
myself frequently disabling it. I'll add it in as another CI action.
@StanczakDominik
Copy link
Member Author

Since I need to break this down in two steps, I'll merge this now and deal with the fallout next.

@StanczakDominik StanczakDominik merged commit 8abf3d0 into PlasmaPy:master Jun 8, 2020
@StanczakDominik StanczakDominik deleted the precommit-in-ci branch June 8, 2020 10:23
@namurphy namurphy added GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) linters Code linters and autoformatters labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) linters Code linters and autoformatters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize PR-side style checks
2 participants