Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more changelog info to PR template #843

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Add more changelog info to PR template #843

merged 3 commits into from
Jun 8, 2020

Conversation

StanczakDominik
Copy link
Member

@StanczakDominik StanczakDominik commented Jun 7, 2020 •
edited
Loading

Closes #811

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

@codecov
Copy link

codecov bot commented Jun 7, 2020 •
edited
Loading

Codecov Report

Merging #843 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          56       56           
  Lines        5127     5127           
=======================================
  Hits         4916     4916           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256413a...85f438e. Read the comment docs.

rocco8773
rocco8773 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's just a few suggested wording and punctuation changes.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
changelog/README.rst Outdated Show resolved Hide resolved
@StanczakDominik StanczakDominik merged commit f71475a into PlasmaPy:master Jun 8, 2020
@namurphy namurphy added the docs PlasmaPy Docs at http://docs.plasmapy.org label Sep 19, 2020
@StanczakDominik StanczakDominik deleted the 811 branch February 18, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocco8773 rocco8773 rocco8773 approved these changes

Assignees
No one assigned
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changelog instructions -> docs, PR template?
3 participants
@StanczakDominik @rocco8773 @namurphy