Mag reynolds #820
Merged
Mag reynolds #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(#PlasmaPy 815)
|
Hello @KhalilBryant! Thanks for updating your pull request. Congratulations! There are no PEP8 issues in this pull request. 😸 Comment last updated at 2020-05-31 18:02:47 UTC |
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 56 56
Lines 5117 5124 +7
=======================================
+ Hits 4906 4913 +7
Misses 211 211
Continue to review full report at Codecov.
|
|
I merged the PR for Reynolds, could you merge those changes in? I squashed them into a single commit so as to make the git history tree less verbose. |
# Conflicts: # plasmapy/formulary/dimensionless.py # plasmapy/formulary/tests/test_dimensionless.py
rocco8773
added
the
plasmapy.formulary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog/README.rstfor instructions, and if you need help with picking the PR type, ask!)docstrings. (Tests pop up at the bottom, in the checks box).
they're failing, ask!).
This Pull request partially solves Create functionality for calculating dimensionless plasma parameters #49 and covers part of New dimensionless parameter prandtl number #769
It also merged all of Reynolds #815 with it