Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relativistic_energy to the Formulary #805

Merged
merged 51 commits into from
May 19, 2020

Conversation

KhalilBryant
Copy link
Contributor

@KhalilBryant KhalilBryant commented May 10, 2020

  • I have added a changelog entry for this pull request (please see
    changelog/README.rst for instructions, and if you need help with picking the PR type, ask!)
  • If adding new functionality, I have added (passing) tests and
    docstrings. (Tests pop up at the bottom, in the checks box).
  • I have fixed any new failing tests (if you're unsure why
    they're failing, ask!).

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          56       56           
  Lines        5113     5113           
=======================================
  Hits         4902     4902           
  Misses        211      211           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba823f8...ba823f8. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented May 12, 2020

Hello @KhalilBryant! Thanks for updating your pull request.

Line 90:51: W291 trailing whitespace
Line 94:71: W291 trailing whitespace
Line 96:1: W293 blank line contains whitespace
Line 100:1: W293 blank line contains whitespace
Line 150:100: E501 line too long (100 > 99 characters)

Line 49:100: E501 line too long (111 > 99 characters)
Line 57:100: E501 line too long (106 > 99 characters)

Comment last updated at 2020-05-19 22:45:26 UTC

@rocco8773 rocco8773 changed the title Khalil bryant patch 1 Add relativistic_energy to the Formulary May 13, 2020
@rocco8773 rocco8773 assigned rocco8773 and KhalilBryant and unassigned rocco8773 May 13, 2020
@rocco8773 rocco8773 added plasmapy.formulary Related to the plasmapy.formulary subpackage needs changelog entry See: https://docs.plasmapy.org/en/latest/contributing/changelog_guide.html labels May 13, 2020
@rocco8773 rocco8773 added this to the v0.4.0 milestone May 13, 2020
@rocco8773 rocco8773 requested review from namurphy and rocco8773 May 13, 2020 00:05
@KhalilBryant KhalilBryant marked this pull request as ready for review May 19, 2020 18:45
Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this is looking almost done. There's only a few minor changes left and then I'll be happy to merge it!

plasmapy/formulary/relativity.py Outdated Show resolved Hide resolved
plasmapy/formulary/relativity.py Outdated Show resolved Hide resolved
plasmapy/formulary/relativity.py Outdated Show resolved Hide resolved
plasmapy/formulary/relativity.py Outdated Show resolved Hide resolved
plasmapy/formulary/tests/test_relativity.py Outdated Show resolved Hide resolved
@rocco8773 rocco8773 merged commit b20e47b into PlasmaPy:master May 19, 2020
@KhalilBryant KhalilBryant deleted the KhalilBryant-patch-1 branch May 19, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog entry See: https://docs.plasmapy.org/en/latest/contributing/changelog_guide.html plasmapy.formulary Related to the plasmapy.formulary subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants