Set isort settings to be consistent with black #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default settings for isort (which sorts imports) and black (which strictly formats code) are not consistent with each other. This sets the default settings for isort to be consistent with black. If you run black and isort once, then switching between them afterward will lead to no changes.
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 55 55
Lines 4971 4971
=======================================
Hits 4784 4784
Misses 187 187Continue to review full report at Codecov.
|
rocco8773
reviewed
Mar 24, 2020
StanczakDominik
approved these changes
Mar 24, 2020
This is for consistency with the default line length for the black code formatter.
StanczakDominik
added a commit
to StanczakDominik/PlasmaPy
that referenced
this pull request
Apr 22, 2020
PlasmaPy#773 added settings for isort, but didn't actually add isort to the suite.
StanczakDominik
added a commit
that referenced
this pull request
Apr 24, 2020
* Remove sunpy image-test tox-env * Allow plot display from tests using PLASMAPY_PLOT_TESTS=1 * Add pip to environment.yml conda nags you about not having pip as a dependency when including pip dependencies such as numpydoc and pytest here. * Add isort to pre-commit hooks #773 added settings for isort, but didn't actually add isort to the suite. * Set tox envlist to minimal set This allows simply running `tox` to run the main package tests via py37 and the documentation, instead of taking in some cases half an hour to run all the env combinations. * Cleanup tox deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default settings for isort (which sorts imports) and black (which strictly formats code) are not consistent with each other. This sets the default settings for isort to be consistent with black. If you run black and isort once, then switching between them afterward will lead to no changes.