Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup files cleanup #771

Merged
merged 5 commits into from
Mar 4, 2020
Merged

Setup files cleanup #771

merged 5 commits into from
Mar 4, 2020

Conversation

StanczakDominik
Copy link
Member

@StanczakDominik StanczakDominik commented Mar 1, 2020 •
edited
Loading

This is a followup to #763 that removes some lint from setup.py and setup.cfg
and uses pkg_resources, which is provided with setuptools and which basically
everyone is going to have, to do what #763 did, but in less code. I also
managed to do without the version.py file, which should simplify things.

  • I have added a changelog entry for this pull request (please see
    changelog/README.rst for instructions, and if you need help with picking the PR type, ask!)
  • If adding new functionality, I have added (passing) tests and
    docstrings. (Tests pop up at the bottom, in the checks box).
  • I have fixed any new failing tests (if you're unsure why
    they're failing, ask!).

@StanczakDominik
Simplify version check using pkg_resources
73bfe7b 
This is a follow-up simplification for PlasmaPy#763.

I picked this up while reading an xarray PR from @crusadersky:
https://github.com/pydata/xarray/pull/3714/files
@StanczakDominik
Simplify version.py file out
2a339f5 
as far as I can tell, it has no actual use if we can simply use pkg_resources
@StanczakDominik
Further setup cleanup
1370c64
@StanczakDominik
Remove perhaps the last leftover of astropy_helpers
767e712 
... a man can dream!
@StanczakDominik
Copy link
Member Author

StanczakDominik commented Mar 1, 2020 •
edited
Loading

Also, cheers to xarray, I was going through a couple of their setup/CI prs and thought I could use those - thus this PR!

@codecov
Copy link

codecov bot commented Mar 1, 2020 •
edited
Loading

Codecov Report

Merging #771 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage    96.2%   96.23%   +0.02%     
==========================================
  Files          55       55              
  Lines        4933     4971      +38     
==========================================
+ Hits         4746     4784      +38     
  Misses        187      187
Impacted Files Coverage Δ
plasmapy/__init__.py 63.15% <100%> (+6.9%) ⬆️
plasmapy/utils/decorators/helpers.py 100% <0%> (ø) ⬆️
plasmapy/classes/sources/plasma3d.py 100% <0%> (ø) ⬆️
plasmapy/utils/decorators/checks.py 100% <0%> (ø) ⬆️
plasmapy/classes/sources/plasmablob.py 100% <0%> (ø) ⬆️
plasmapy/particles/particle_input.py 100% <0%> (ø) ⬆️
plasmapy/utils/decorators/validators.py 100% <0%> (ø) ⬆️
plasmapy/formulary/braginskii.py 99.72% <0%> (ø) ⬆️
plasmapy/particles/particle_class.py 96.64% <0%> (ø) ⬆️
plasmapy/utils/pytest_helpers/pytest_helpers.py 93.4% <0%> (+0.02%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9943fd...8b87913. Read the comment docs.

namurphy
namurphy approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm not sure why the documentation test is stalling.

setup.cfg
Comment on lines -78 to -79
[ah_bootstrap]
auto_use = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't realize that we still had that in here.

@StanczakDominik StanczakDominik force-pushed the xarray-pkging-changes branch from 26ca0eb to 6aabff5 Compare March 3, 2020 20:19
@StanczakDominik StanczakDominik force-pushed the xarray-pkging-changes branch from 6aabff5 to 8b87913 Compare March 3, 2020 20:27
@StanczakDominik
Copy link
Member Author

StanczakDominik commented Mar 3, 2020 •
edited
Loading

Oh yeah, I did get an email from circleci about them switching everything to their new pipelines setup, and given that nothing seemed to be exploding, I promptly ignored it. 💥
I think this should be fixed now, and this PR can be merged; if this issue arises again in the future on some other PR, please @ me and I'll see what I can do about it.

@namurphy
Copy link
Member

namurphy commented Mar 4, 2020

I think this should be fixed now, and this PR can be merged; if this issue arises again in the future on some other PR, please @ me and I'll see what I can do about it.

Thanks! Everything looks great, so I'll go ahead and merge it.

@namurphy namurphy merged commit 10287a3 into PlasmaPy:master Mar 4, 2020
rocco8773 added a commit that referenced this pull request Mar 29, 2020
@rocco8773
Revert "Setup files cleanup (#771)"
4baf9ed 
This reverts commit 10287a3.
@rocco8773 rocco8773 mentioned this pull request Mar 30, 2020
Merged
@StanczakDominik StanczakDominik deleted the xarray-pkging-changes branch April 30, 2020 13:16
@namurphy namurphy added the packaging Related to packaging or distribution label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namurphy namurphy namurphy approved these changes

Assignees
No one assigned
Labels
packaging Related to packaging or distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanczakDominik @namurphy