Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freqto hz test doc #756

Merged
merged 6 commits into from
Feb 5, 2020
Merged

Freqto hz test doc #756

merged 6 commits into from
Feb 5, 2020

Conversation

diego7319
Copy link
Contributor

  • Hello, I wanted to add some minor details to the documentation in the test_converters.py

@pep8speaks
Copy link

pep8speaks commented Feb 5, 2020 •
edited
Loading

Hello @diego7319! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated at 2020-02-05 02:35:37 UTC

@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #756 into master will decrease coverage by <.01%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #756      +/-   ##
=========================================
- Coverage   96.21%   96.2%   -0.01%     
=========================================
  Files          55      55              
  Lines        4909    4932      +23     
=========================================
+ Hits         4723    4745      +22     
- Misses        186     187       +1
Impacted Files Coverage Δ
plasmapy/particles/__init__.py 100% <ø> (ø)
plasmapy/particles/isotopes.py 100% <ø> (ø)
plasmapy/particles/symbols.py 100% <ø> (ø)
plasmapy/particles/elements.py 100% <ø> (ø)
plasmapy/particles/exceptions.py 100% <ø> (ø)
plasmapy/particles/nuclear.py 100% <100%> (ø)
plasmapy/simulation/particletracker.py 98.27% <100%> (ø) ⬆️
plasmapy/diagnostics/langmuir.py 93.21% <100%> (ø) ⬆️
plasmapy/particles/particle_class.py 96.63% <100%> (ø)
plasmapy/formulary/magnetostatics.py 100% <100%> (+0.78%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfeea4e...e9d9b7f. Read the comment docs.

StanczakDominik
StanczakDominik approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like more tests rather than more documentation, but LGTM!

@namurphy namurphy self-requested a review February 5, 2020 17:24
@namurphy namurphy merged commit 0747961 into PlasmaPy:master Feb 5, 2020
@namurphy namurphy added testing plasmapy.utils Related to the plasmapy.utils subpackage labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanczakDominik StanczakDominik StanczakDominik approved these changes

@namurphy namurphy namurphy approved these changes

Assignees
No one assigned
Labels
plasmapy.utils Related to the plasmapy.utils subpackage testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diego7319 @pep8speaks @namurphy @StanczakDominik