Remove mutable arguments from Particle.is_category method
#751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=========================================
+ Coverage 95.06% 96.26% +1.2%
=========================================
Files 56 55 -1
Lines 5047 4957 -90
=========================================
- Hits 4798 4772 -26
+ Misses 249 185 -64
Continue to review full report at Codecov.
|
jakub-polak
changed the title
is_category functionParticle.is_category method
StanczakDominik
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
That's a fair point, I didn't think of that. LGTM! @namurphy, wanna take a look?
namurphy
added
the
plasmapy.particles
|
Thank you! Looks good to me too, so I'll merge it. I'll create a broader issue for us to check if there are mutable default arguments elsewhere in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are mutable arguments in
Particle.is_categorymethod, that should never be done.Nice article about its 'features' --> https://florimond.dev/blog/articles/2018/08/python-mutable-defaults-are-the-source-of-all-evil/
So the mutable arguments are removed and replaced by
Nonewith handling bybecome_setsimilarly as it was before.