Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up main namespace #718

Merged
merged 8 commits into from
Nov 19, 2019

Conversation

StanczakDominik
Copy link
Member

@StanczakDominik StanczakDominik commented Nov 3, 2019

  • I have added a changelog entry for this pull request (please see
    changelog/README.rst for instructions, and if you need help with picking the PR type, ask!)
  • If adding new functionality, I have added (passing) tests and
    docstrings. (Tests pop up at the bottom, in the checks box).
  • I have fixed any new failing tests (if you're unsure why
    they're failing, ask!).

@pep8speaks
Copy link

pep8speaks commented Nov 3, 2019

Hello @StanczakDominik! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated at 2019-11-03 12:47:40 UTC

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #718 into master will increase coverage by 0.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #718     +/-   ##
=========================================
+ Coverage   95.02%   95.63%   +0.6%     
=========================================
  Files          57       55      -2     
  Lines        4722     4670     -52     
=========================================
- Hits         4487     4466     -21     
+ Misses        235      204     -31
Impacted Files Coverage Δ
plasmapy/version.py 33% <ø> (-0.67%) ⬇️
plasmapy/__init__.py 58.82% <100%> (+5.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da93bf...5e12e3e. Read the comment docs.

@StanczakDominik
Copy link
Member Author

Right, that should do it:

[ins] In [3]: dir(plasmapy)          
Out[3]: 
['__builtins__',
 '__cached__',
 '__citation__',
 '__doc__',
 '__file__',
 '__githash__',
 '__loader__',
 '__name__',
 '__package__',
 '__path__',
 '__spec__',
 '__version__',
 'atomic',
 'formulary',
 'online_help',
 'utils']

I'll still remove some unnecessary files from the main source directory.

This was a packaging workaround that I'm very curious to see if it's breaking stuff again...
@StanczakDominik StanczakDominik added the status: ready for review PRs that are ready for code review label Nov 13, 2019
plasmapy/version.py Show resolved Hide resolved
@StanczakDominik StanczakDominik merged commit 97cffd2 into PlasmaPy:master Nov 19, 2019
@StanczakDominik StanczakDominik deleted the CleanUpMainNamespace branch November 19, 2019 19:11
@namurphy namurphy removed the status: ready for review PRs that are ready for code review label Aug 15, 2022
@namurphy namurphy added the maintenance General updates to package infrastructure label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General updates to package infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants