Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix h5py file warning #717

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Fix h5py file warning #717

merged 2 commits into from
Nov 2, 2019

Conversation

lgoenner
Copy link
Contributor

This PR fixes the h5py warning during the build.

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #717 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          57       57           
  Lines        4722     4722           
=======================================
  Hits         4487     4487           
  Misses        235      235
Impacted Files Coverage Δ
plasmapy/classes/sources/openpmd_hdf5.py 80.23% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef86757...fb56071. Read the comment docs.

@StanczakDominik
Copy link
Member

Hey, I went ahead and added the missing changelog entry :)

This looks good and I'll be merging it as soon as tests pass. Thanks!

@StanczakDominik StanczakDominik merged commit 2e7b06e into PlasmaPy:master Nov 2, 2019
@namurphy namurphy added the maintenance General updates to package infrastructure label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General updates to package infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants