Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style improvements #716

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Style improvements #716

merged 3 commits into from
Nov 2, 2019

Conversation

flaixman
Copy link
Contributor

This PR doesn't solve bugs, but improves the actual style guide of python3 in some modules using pylint3 as a standard score.

Great project!

@pep8speaks
Copy link

pep8speaks commented Oct 30, 2019

Hello @flaixman! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated at 2019-11-02 20:41:31 UTC

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          57       57           
  Lines        4722     4722           
=======================================
  Hits         4487     4487           
  Misses        235      235
Impacted Files Coverage Δ
plasmapy/atomic/isotopes.py 100% <100%> (ø) ⬆️
plasmapy/atomic/atomic.py 100% <100%> (ø) ⬆️
plasmapy/atomic/parsing.py 99.45% <100%> (ø) ⬆️
plasmapy/atomic/symbols.py 100% <100%> (ø) ⬆️
plasmapy/atomic/elements.py 100% <100%> (ø) ⬆️
plasmapy/atomic/nuclear.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef86757...3b219ec. Read the comment docs.

@StanczakDominik
Copy link
Member

Looks good, I went ahead and added a changelog entry :)

@StanczakDominik StanczakDominik merged commit 7da93bf into PlasmaPy:master Nov 2, 2019
@namurphy namurphy added the maintenance General updates to package infrastructure label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General updates to package infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants