Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository housekeeping varia, python 3.8 tests #712

Merged
merged 8 commits into from
Nov 21, 2019
Merged

Repository housekeeping varia, python 3.8 tests #712

merged 8 commits into from
Nov 21, 2019

Conversation

StanczakDominik
Copy link
Member

@StanczakDominik StanczakDominik commented Oct 25, 2019 •
edited
Loading

This implements https://github.com/OpenAstronomy/azure-pipelines-templates for CI.

Closes #635, closes #424.

@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files          55       55           
  Lines        4670     4670           
=======================================
  Hits         4466     4466           
  Misses        204      204
Impacted Files Coverage Δ
plasmapy/atomic/atomic.py 100% <ø> (ø) ⬆️
plasmapy/atomic/nuclear.py 100% <ø> (ø) ⬆️
plasmapy/formulary/parameters.py 98.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97cffd2...810fc1d. Read the comment docs.

@StanczakDominik
Copy link
Member Author

The py37-astropydev error is a result of #653 and I'm still not sure how to handle it

I will also add #424 here

@StanczakDominik
Copy link
Member Author

StanczakDominik commented Oct 26, 2019 •
edited
Loading

  • py36-minimal-conda [linux]) is failing due to calls to units.quantity.allclose, which either wasn't there yet or was in another namespace back in Astropy 2.0. But I think simply bumping the minimum to 3.0, or even 3.1 as I seem to remember some breakage, would be more sensible.
  • py37-astropydev [linux] is all All our numerical docstring outputs broke on Astropy.constants value updates #653, and I think it could be possible to fix most of it via atols. I'll try it tomorrow or so.

I'm also liking how local access to these envs is more comfortable now.

@StanczakDominik
Copy link
Member Author

Also, @Cadair, consider this tested and I've got only positive feedback for you :) it seems to be working like a charm.

@StanczakDominik
Copy link
Member Author

I've decided to bump the minimum required versions of

@namurphy
Copy link
Member

As much as I'll miss broken doctests, bumping the minimum version of NumPy to 1.14 sounds like a good idea to me. Same for bumping minimum Astropy to 3.1. Thanks!

@StanczakDominik
Copy link
Member Author

Turns out the astropydev problem consists of a bunch of different problems and I'd much rather merge this now, then figure out fixes for each...

@pep8speaks
Copy link

pep8speaks commented Nov 4, 2019 •
edited
Loading

Hello @StanczakDominik! Thanks for updating your pull request.

Congratulations! There are no PEP8 issues in this pull request. 😸

Comment last updated at 2019-11-20 13:50:49 UTC

@StanczakDominik
Copy link
Member Author

ELLIPSIS seems broken within astropy/pytest-doctestplus, I'll try to report that there, but most definitely not tonight.

For now, I'm instead going to get rid of pytest-astropy, as I'm realizing we're not actually using any of its functionality except FLOAT_CMP, and that can be reproduced with pytest >= 5.1 via the NUMBER flag.

I'm frustrated, so I shall now vent with a witty video:

https://www.youtube.com/watch?v=djZkTnJnLR0

@StanczakDominik StanczakDominik force-pushed the IncorporateCadairAwesomeAzureSolution branch from 7257dfb to c4d24c9 Compare November 13, 2019 19:57
@StanczakDominik
Copy link
Member Author

https://www.youtube.com/watch?v=AXwGVXD7qEQ

except for 3.8 failing on pip installing hdf5, and astropy-dev is still failing, but that's still PROGRESS!

@Cadair
Copy link
Contributor

Cadair commented Nov 14, 2019

I think you might be able to solve your hdf5 issue by installing the hdf5 c lib with apt.

@StanczakDominik StanczakDominik force-pushed the IncorporateCadairAwesomeAzureSolution branch 2 times, most recently from 3519644 to 4a5750a Compare November 14, 2019 13:40
@StanczakDominik
Copy link
Member Author

I think I'll just take the lazy route and wait for h5py/h5py#1410 😆

@StanczakDominik StanczakDominik changed the title [WIP] Incorporate Cadair's Azure Pipelines Templates [WIP] Python 3.8 + use Cadair's Azure Pipelines Templates Nov 14, 2019
@Cadair
Copy link
Contributor

Cadair commented Nov 14, 2019

That looks like a troublesome bug in the Azure images...

@StanczakDominik
Use OpenAstronomy Azure Pipelines Templates
807ddc7 
Modifies Azure CI setup as per https://github.com/OpenAstronomy/azure-pipelines-templates
@StanczakDominik
Modify tox test template
68dd8bd 
Adds environments for conda-based setup of packages
Adds an environment with minimal pinned versions of packages
@StanczakDominik
Replace pytest-astropy with Pytest 5.1
0c51217 
The pytest-astropy plugin was not actually used much, except for the
float_cmp option, which comes with pytest 5.1 and does not require
another package.

Removes sphinx-astropy as well.
@StanczakDominik
Bump minimal package versions
3f27715
@StanczakDominik
Remove obsolete information on testing source build from install guide
e39328a
@StanczakDominik
Fix testing instructions in docs to use tox
bf368c7
@StanczakDominik
Fix some of the failing docstring tests
a096883
@StanczakDominik
Changelog entry
810fc1d
@StanczakDominik StanczakDominik force-pushed the IncorporateCadairAwesomeAzureSolution branch from dec4704 to 810fc1d Compare November 20, 2019 13:50
@StanczakDominik StanczakDominik changed the title [WIP] Python 3.8 + use Cadair's Azure Pipelines Templates Repository housekeeping varia, python 3.8 tests Nov 20, 2019
namurphy
namurphy approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

docs/install.rst
@@ -19,9 +19,9 @@ PlasmaPy requires Python version 3.6 or newer, and is not compatible
with Python 2.7. PlasmaPy requires the following packages for
installation:

- `NumPy <http://www.numpy.org/>`_ 1.13 or newer
- `NumPy <http://www.numpy.org/>`_ 1.14 or newer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there was much rejoicing

@StanczakDominik StanczakDominik merged commit 294101b into PlasmaPy:master Nov 21, 2019
@StanczakDominik StanczakDominik deleted the IncorporateCadairAwesomeAzureSolution branch November 21, 2019 19:28
@StanczakDominik StanczakDominik mentioned this pull request Apr 22, 2020
Closed
@namurphy namurphy mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namurphy namurphy namurphy approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python 3.8 to testing matrix Test against minimum versions of required packages
4 participants
@StanczakDominik @namurphy @pep8speaks @Cadair