Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation subpackage #665

Merged
merged 4 commits into from
Aug 21, 2019
Merged

Simulation subpackage #665

merged 4 commits into from
Aug 21, 2019

Conversation

StanczakDominik
Copy link
Member

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jul 22, 2019 •
edited
Loading

Hello @StanczakDominik! Thanks for updating your pull request.

Line 4:22: W292 no newline at end of file

Line 15:1: E302 expected 2 blank lines, found 1

Comment last updated at 2019-07-22 17:06:28 UTC

@codecov
Copy link

codecov bot commented Jul 22, 2019 •
edited
Loading

Codecov Report

Merging #665 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   94.92%   94.92%   -0.01%     
==========================================
  Files          55       55              
  Lines        4670     4669       -1     
==========================================
- Hits         4433     4432       -1     
  Misses        237      237
Impacted Files Coverage Δ
plasmapy/simulation/particletracker.py 98.27% <100%> (ø)
plasmapy/classes/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d5c6c...394e401. Read the comment docs.

@StanczakDominik StanczakDominik marked this pull request as ready for review July 22, 2019 17:58
@StanczakDominik StanczakDominik added the status: ready for review PRs that are ready for code review label Aug 20, 2019
namurphy
namurphy approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

docs/simulation/particletracker.rst
************************************************

Introduction
============

This module contains the `species` class, which is a simple particle
This module contains the `ParticleTracker` class, which is a simple particle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new name!

@StanczakDominik
Copy link
Member Author

All right, thanks for the review @namurphy :)

@StanczakDominik StanczakDominik merged commit 09189fd into PlasmaPy:master Aug 21, 2019
@namurphy namurphy removed the status: ready for review PRs that are ready for code review label Oct 19, 2019
@namurphy namurphy mentioned this pull request Feb 3, 2020
Merged
@StanczakDominik StanczakDominik deleted the simulation branch April 30, 2020 13:15
@namurphy namurphy added the plasmapy.simulation Related to the plasmapy.simulation subpackage label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namurphy namurphy namurphy approved these changes

Assignees
No one assigned
Labels
plasmapy.simulation Related to the plasmapy.simulation subpackage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanczakDominik @pep8speaks @namurphy