Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove astropy_helpers submodule #663

Merged
merged 9 commits into from
Aug 21, 2019
Merged

Remove astropy_helpers submodule #663

merged 9 commits into from
Aug 21, 2019

Conversation

StanczakDominik
Copy link
Member

Closes #660

@codecov
Copy link

codecov bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #663 into master will increase coverage by 0.02%.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   94.92%   94.95%   +0.02%     
==========================================
  Files          55       54       -1     
  Lines        4670     4657      -13     
==========================================
- Hits         4433     4422      -11     
+ Misses        237      235       -2
Impacted Files Coverage Δ
plasmapy/_base_init.py 56% <54.16%> (-10.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d5c6c...cf6e692. Read the comment docs.

@StanczakDominik StanczakDominik marked this pull request as ready for review July 11, 2019 06:17
@StanczakDominik
Copy link
Member Author

  • plasmapy.test is broken right now

@StanczakDominik StanczakDominik mentioned this pull request Jul 22, 2019
Closed
@StanczakDominik
Copy link
Member Author

It seems that import plasmapy; plasmapy.test() works, while python setup.py test does not. But I'd honestly much rather just deprecate the latter and use tox instead.

@StanczakDominik StanczakDominik added the status: ready for review PRs that are ready for code review label Aug 20, 2019
namurphy
namurphy approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the memories, astropy-helpers!

ah_bootstrap.py
@@ -1,1010 +0,0 @@
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to miss this file, even though I had no idea what it did.

@StanczakDominik StanczakDominik merged commit 4732d15 into PlasmaPy:master Aug 21, 2019
@StanczakDominik
Copy link
Member Author

Thanks!

@namurphy namurphy mentioned this pull request Sep 5, 2019
Merged
@namurphy namurphy removed the status: ready for review PRs that are ready for code review label Oct 19, 2019
@StanczakDominik StanczakDominik deleted the RemoveAstropyHelpers branch April 30, 2020 13:16
@namurphy namurphy added the maintenance General updates to package infrastructure label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namurphy namurphy namurphy approved these changes

Assignees
No one assigned
Labels
maintenance General updates to package infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove astropy_helpers
2 participants
@StanczakDominik @namurphy