Nuke plasmapy.constants #651
Conversation
Most plasmapy.constants imports were changed to astropy.constants Electrons are weird so those were changed to astropy.constants.si where necessary Astropy.constants lacks pi, so that was imported from NumPy
StanczakDominik
force-pushed
the
StanczakDominik-patch-2
branch
from
8ee1643 to
799cea4
Compare
Also rename changelog entry to previous PR
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 96.51% 96.51% +<.01%
==========================================
Files 54 54
Lines 4558 4563 +5
==========================================
+ Hits 4399 4404 +5
Misses 159 159
Continue to review full report at Codecov.
|
StanczakDominik
force-pushed
the
StanczakDominik-patch-2
branch
2 times, most recently
from
8ee1643 to
b6944db
Compare
namurphy
added
physical data
There was a problem hiding this comment.
Thinking about this more, this does make sense as long as there are no constants that are specific to plasma physics that are not in astropy.constants. If there are some constants that we end up needing in the future, then probably the better thing to do would be to propose an upstream change to astropy.constants instead.
It would be helpful to include some documentation to remind users that they should go to astropy.constants for the physical constants that they need, which could be either in this PR or raised as an issue for the future.
|
Good point on the docs! If there are any constants that are irrelevant to astronomy (as per documentation to |
I thought we had done that a while ago.
plasmapy.constantsis purely a wrapper forastropy.constants. It provides no useful functionality of its own except introducing confusion.Off with its HEAD, as they say.