Remove usage of distutils
#1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plasmapy.plasma
Codecov Report
@@ Coverage Diff @@
## main #1306 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 73 73
Lines 7169 7169
=======================================
Hits 6961 6961
Misses 208 208
Continue to review full report at Codecov.
|
rocco8773
reviewed
Oct 14, 2021
rocco8773
approved these changes
Oct 14, 2021
rocco8773
reviewed
Oct 14, 2021
setup.cfg
Outdated
| @@ -50,6 +50,7 @@ install_requires = | |||
| setuptools >= 41.2 | |||
| tqdm >= 4.41.0 | |||
| xarray >= 0.14.0 | |||
| packaging | |||
There was a problem hiding this comment.
I'm surprised black and/or pre-commit are not complaining that this is not alphabetized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutilshas just been deprecated, so this PR is to remove usage of distutils in one file. In particular, I replaceddistutils.version.StrictVersionwithpackaging.version.Version. I don't know yet if I need to addpackagingas a dependency.Closes #1293.