Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and apply pre-commit hooks for .ini, .toml, and .yaml files #1284

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

namurphy
Copy link
Member

This PR adds some pre-commit autoformatters for .ini, .toml, and .yaml files, and applies changes from those autoformatters ∀ files ∈PlasmaPy.

There don't seem to be many customization options, but autoformatters for all of these file types were available together so I'm guessing that they should all produce consistent styles.

@github-actions github-actions bot added the CI Related to continuous integration label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1284 (da81d10) into main (16d2de1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files          73       73           
  Lines        7106     7106           
=======================================
  Hits         6898     6898           
  Misses        208      208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d2de1...da81d10. Read the comment docs.

@namurphy namurphy requested a review from a team September 29, 2021 18:24
@namurphy
Copy link
Member Author

One worry I had with some of the changes is that many strings that included * are no longer in quotes. I think that this is fine, given this description of YAML syntax talks about strings that start with *. There's a chance I'm wrong about this, so if this PR causes problems, this would be a good place to look.

@namurphy namurphy merged commit 727513d into PlasmaPy:main Sep 29, 2021
@namurphy namurphy deleted the static-analysis-4 branch September 29, 2021 20:22
Tlord18 pushed a commit to Tlord18/PlasmaPy that referenced this pull request Oct 6, 2021
…PlasmaPy#1284)

* Add pre-commit hooks for ini/toml/yaml files

* Apply formatting changes to YAML files

* Apply formatting changes to tox.ini

* Add changelog entry

* Add link to pre-commit
Tlord18 pushed a commit to Tlord18/PlasmaPy that referenced this pull request Oct 6, 2021
…PlasmaPy#1284)

* Add pre-commit hooks for ini/toml/yaml files

* Apply formatting changes to YAML files

* Apply formatting changes to tox.ini

* Add changelog entry

* Add link to pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants