Fix some broken and redirected links #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
Codecov Report
@@ Coverage Diff @@
## main #1257 +/- ##
=======================================
Coverage ? 97.06%
=======================================
Files ? 73
Lines ? 7095
Branches ? 0
=======================================
Hits ? 6887
Misses ? 208
Partials ? 0 Continue to review full report at Codecov.
|
namurphy
commented
Sep 7, 2021
namurphy
commented
Sep 7, 2021
Comment on lines
+1110
to
+1112
| .. [3] `Draft Material for "Fundamentals of Plasma Physics" Book | ||
| <https://docs.google.com/document/d/e/2PACX-1vQmvQ_b8p0P2cYsWGMQYVd92OBLX9Sm6XGiCMRBidoVSoJffj2MBvWiwpix46mqlq_HQvHD5ofpfrNF/pub>`__, | ||
| by James D. Callen |
There was a problem hiding this comment.
This is a pretty fragile link, so I'm tempted to replace this a more persistent publication later on. (It also gets repeated a bunch of times so I had to copy & paste a bunch, which gives me more motivation for a unified set of references as in #1245.)
|
This should be a pretty quick review. If it looks good to you, please feel free to merge. |
StanczakDominik
approved these changes
Sep 8, 2021
Co-authored-by: Dominik Stańczak <[email protected]>
Co-authored-by: Dominik Stańczak <[email protected]>
Tlord18
pushed a commit
to Tlord18/PlasmaPy
that referenced
this pull request
Oct 6, 2021
* Update links in docs * Fix links in docs * Add links in docs * Update links in collisions.py * Fix links in docs * Fix links in docs * Fix link in docs * Fix PR number in 0.3.0.rst plus some reST edits * Remove unnecessary line * Fix a few more fragile links * Add changelog entry * Use permalink for a Wikipedia article Co-authored-by: Dominik Stańczak <[email protected]> * Add in renamed GitHub profile Co-authored-by: Dominik Stańczak <[email protected]> * Fix reST formatting Co-authored-by: Dominik Stańczak <[email protected]>
Tlord18
pushed a commit
to Tlord18/PlasmaPy
that referenced
this pull request
Oct 6, 2021
* Update links in docs * Fix links in docs * Add links in docs * Update links in collisions.py * Fix links in docs * Fix links in docs * Fix link in docs * Fix PR number in 0.3.0.rst plus some reST edits * Remove unnecessary line * Fix a few more fragile links * Add changelog entry * Use permalink for a Wikipedia article Co-authored-by: Dominik Stańczak <[email protected]> * Add in renamed GitHub profile Co-authored-by: Dominik Stańczak <[email protected]> * Fix reST formatting Co-authored-by: Dominik Stańczak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few quick corrections to web links that were either broken or were redirects. One of the changes is for an old changelog entry that had linked to the issue it closed rather than the pull request number. I found these out doing
make linkcheckindocs/which was pretty handy. (I made a reST update here and there while I was the area too.)