added property based tests using hypothesis #1249
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage ? 97.06%
=======================================
Files ? 73
Lines ? 7095
Branches ? 0
=======================================
Hits ? 6887
Misses ? 208
Partials ? 0 Continue to review full report at Codecov.
|
|
All right, I ran the test myself locally, swapping out for the (allegedly) book-prescribed expression and it does indeed start failing then! I tried limiting the minimum value of So that's weird. We should look in #910 and see whether there was not any discussion in there... @qudsiramiz, do you happen to still have access to that book? Also cc @namurphy from the previous issue! |
|
I have now changed to comments so that they reference the NRL Formulary rather than Fried and Conte for the symmetry properties of Z |
|
Oh wait, the NRL formulary has the formula as the one we have in here?! Okay, awesome, in that case this is a swift merge :) Let me just apply style fixes... pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
The xarray-dev test is failing for a completely unrelated reason. I'd say "get this in there right now", but I'd like to have a fix first. But this is completely ready for merge once I have that prepared! Thanks, @14tstinson !
|
@StanczakDominik @namurphy Thanks for making my first contribution experience a good one! |
|
The test failure disappeared after a subsequent re-run. I suspect it was something broken upstream. Oh well, let's merge it! Thanks once again, @14tstinson ! |
* added property based tests using hypothesis * updated comments for accuracy * added changelog entry * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Minor changelog text fix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dominik Stańczak <[email protected]>
* added property based tests using hypothesis * updated comments for accuracy * added changelog entry * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Minor changelog text fix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dominik Stańczak <[email protected]>
Closes #1242
docstrings.