Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken reST links in old changelogs #1207

Merged
merged 13 commits into from
Jul 27, 2021

Conversation

namurphy
Copy link
Member

This PR is a spin-off of #1206 in order to fix the warnings associated with broken reST links. I'm limiting the scope of this PR to fixing links, without making any substantive changes to the changelog otherwise. Thus far I've been able to get us from 1466 to 908 warnings.

My main motivation for this pull request is that we really ought to enable the nitpicky (-n) option in sphinx-build in the documentation tests for each pull request. That way, we would be able to catch broken links before they make their way into the repository. Before we can enable that option...however...we have to fix the broken links that are currently in the documentation, which were largely concentrated in old changelogs as references to stuff that doesn't exist anymore.

I removed the |PhysicalType| substitution since it's in Astropy 4.3+ only, and because it's not used anywhere in PlasmaPy (yet).

I also avoided using substitutions for code within PlasmaPy because the locations of objects sometimes changes with time, and the changelog should reflect the state of the repository at that time.

@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@df46639). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage        ?   96.98%           
=======================================
  Files           ?       71           
  Lines           ?     7030           
  Branches        ?        0           
=======================================
  Hits            ?     6818           
  Misses          ?      212           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df46639...35adf42. Read the comment docs.

@StanczakDominik
Copy link
Member

StanczakDominik commented Jul 27, 2021

My main motivation for this pull request is that we really ought to enable the nitpicky (-n) option in sphinx-build in the documentation tests for each pull request. That way, we would be able to catch broken links before they make their way into the repository. Before we can enable that option...however...we have to fix the broken links that are currently in the documentation, which were largely concentrated in old changelogs as references to stuff that doesn't exist anymore.

Good call! It's probably best to make a one liner PR with that change and just periodically merge main into it.

Missed the fact that you've already done that!


.. _change-log-0.2.0-api:

Changes to API
--------------

- Move `~plasmapy.transport` from `~plasmapy.physics` to its own
- Move ``plasmapy.transport`` from ``plasmapy.physics`` to its own
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh.

to bug outlined in issue `<https://github.com/PlasmaPy/PlasmaPy/issues/726>`_. Associated pytests
are marked with `pytest.mark.xfails` and doctests are marked with `doctests: +SKIP`. (`#722 <https://github.com/plasmapy/plasmapy/pull/722>`__)
are marked with ``pytest.mark.xfails`` and doctests are marked with ``doctests: +SKIP``. (`#722 <https://github.com/plasmapy/plasmapy/pull/722>`__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's xfail, actually, and we just had a typo in here. But, whatever.

@StanczakDominik StanczakDominik enabled auto-merge (squash) July 27, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants