Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gyrofrequency more general (not just ions) #1183

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

alfkoehn
Copy link
Contributor

@alfkoehn alfkoehn commented Jul 1, 2021

Make the gyrofrequency function more general by removing the, originally included, indications that it might only be the gyrofrequency for the ions. Should close #1169

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

@github-actions github-actions bot added the plasmapy.formulary Related to the plasmapy.formulary subpackage label Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@5f5717c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage        ?   96.98%           
=======================================
  Files           ?       71           
  Lines           ?     7022           
  Branches        ?        0           
=======================================
  Hits            ?     6810           
  Misses          ?      212           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5717c...5a7b360. Read the comment docs.

Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@namurphy namurphy merged commit 822c97f into PlasmaPy:main Jul 1, 2021
@alfkoehn alfkoehn deleted the make_gyrofrequency_general branch July 1, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.formulary Related to the plasmapy.formulary subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit gyrofrequency function to better indicate that it's not just for ions
2 participants