Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some physics into about lower-hybrid frequency #1181

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

alfkoehn
Copy link
Contributor

@alfkoehn alfkoehn commented Jun 30, 2021

Triggered by the hack-week, I added a little bit of physics information about the lower-hybrid resonance.

Together with #1180, this should close #1172

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

@github-actions github-actions bot added the plasmapy.formulary Related to the plasmapy.formulary subpackage label Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@5f5717c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1181   +/-   ##
=======================================
  Coverage        ?   96.98%           
=======================================
  Files           ?       71           
  Lines           ?     7022           
  Branches        ?        0           
=======================================
  Hits            ?     6810           
  Misses          ?      212           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5717c...9d4ac2b. Read the comment docs.

Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again! One suggested wording change, and otherwise looks good.

plasmapy/formulary/parameters.py Outdated Show resolved Hide resolved
Fix typo.

Co-authored-by: Nick Murphy <[email protected]>
Copy link
Member

@namurphy namurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you once again!

@namurphy namurphy merged commit 874faa6 into PlasmaPy:main Jun 30, 2021
@alfkoehn alfkoehn deleted the update_LH_docstring branch July 1, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.formulary Related to the plasmapy.formulary subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe plasma physics behind upper and lower hybrid frequencies
2 participants