Input ion velocity in thomson notebook #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
the
notebooks
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 71 71
Lines 7022 7022
=======================================
Hits 6810 6810
Misses 212 212 Continue to review full report at Codecov.
|
pheuer
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Looks good to me! Thanks @bryancfoo for catching this omitted line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example dicts used in the thomson notebook contain an "ion_vel" index, but this is not used when calling the spectral_density function at the end. Added a line with the relevant input parameter to correct this.