Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Particle.particle #1146

Merged
merged 2 commits into from
May 20, 2021

Conversation

namurphy
Copy link
Member

This PR removes Particle.particle, which had previously been deprecated in favor of Particle.symbol in #984. This wasn't a widely used feature so it should be fine to have it emit a FutureWarning in 0.6.0, and then to remove it in the next release (0.7.0).

@github-actions github-actions bot added the plasmapy.particles Related to the plasmapy.particles subpackage label May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #1146 (3c8781b) into master (d64c10c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   96.95%   96.98%   +0.02%     
==========================================
  Files          71       71              
  Lines        7026     7022       -4     
==========================================
- Hits         6812     6810       -2     
+ Misses        214      212       -2     
Impacted Files Coverage Δ
plasmapy/particles/particle_class.py 99.10% <ø> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64c10c...3c8781b. Read the comment docs.

@namurphy namurphy enabled auto-merge (squash) May 20, 2021 03:12
Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a magic trick? I'm going to make this property disappear...

@namurphy namurphy merged commit a51e3a6 into PlasmaPy:master May 20, 2021
@namurphy namurphy deleted the remove-particle-dot-particle branch September 10, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.particles Related to the plasmapy.particles subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants