Trying to fix very minor error in ExB_drift.ipynb #1088
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 70 70
Lines 6928 6928
=======================================
Hits 6714 6714
Misses 214 214 ☔ View full report in Codecov by Sentry. |
|
I think I found a solution. Whatever changed in nbsphinx seems to like fig = plt.figure(figsize=(6, 6))
ax = fig.add_subplot(111, projection="3d")more than fig = plt.figure()
ax = fig.gca(projection="3d")Probably only a problem when making 3D plots with matplotlib, which is why we aren't seeing this error everywhere? |
There was a problem hiding this comment.
If it works, it works! I don't think that's a nbsphinx issue; there have been no recent release there. Matplotlib, on the other hand, did release 3.4.0 just yesterday. They probably deprecated that, or some such? The gca syntax felt wonky, anyway, so thanks for this cleanup!
Started getting a CI error related to the thumbnail in this notebook. Trying to fix it in this PR just by splitting up some cells.
The error:
Relevant documentation: https://nbsphinx.readthedocs.io/en/latest/code-cells.html#Plots