Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature freeze and code freeze to timeline #1081

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

namurphy
Copy link
Member

Here's a first attempt at including a feature freeze and code freeze in our release guide, which we can iterate upon. Closes #1078.

 - Add feature freeze instruction
 - Make minor formatting edits
@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (92b9f70) to head (e20a990).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          70       70           
  Lines        6929     6929           
=======================================
  Hits         6715     6715           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a single comment:

@@ -18,6 +17,15 @@ and ``0.5.0`` denotes the last released version.
Release
-------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a Pre-Release header for these. This is like when you sit down to make kimchi and the recipe starts with "put the cabbage into salted water for three hours".

As per the discussion in PlasmaPy#1081, this commit adds a "pre-release" section
into the release guide.
@StanczakDominik StanczakDominik merged commit 79b2ad7 into PlasmaPy:master Mar 16, 2021
@namurphy namurphy deleted the feature-freeze branch September 10, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature freeze to release procedure
2 participants