PRad Bugfix #1035
Merged
PRad Bugfix #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1035 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 69 69
Lines 6737 6737
=======================================
Hits 6523 6523
Misses 214 214 ☔ View full report in Codecov by Sentry. |
StanczakDominik
approved these changes
Feb 23, 2021
| with pytest.warns(RuntimeWarning): | ||
| sim.run(field_weighting="nearest neighbor", dt=1e-12 * u.s) | ||
| # Calc max deflection | ||
| sim.max_deflection |
There was a problem hiding this comment.
Would be good to at least have a bounds check (assert lower < sim.max_deflection < upper) here, rather than calculating it just for the non-exception-throwing-execution code coverage!
There was a problem hiding this comment.
Good idea - I've set a bound between 0 and pi/2 (which is valid for particles with a small max_theta).
rocco8773
added a commit
to rocco8773/PlasmaPy
that referenced
this pull request
Mar 14, 2021
namurphy
added
the
plasmapy.diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few minor bugs in sections of
proton_radiography.SyntheticProtonRadiographthat I used rarely:Accessing the
max_deflectionproperty raised an exception if particles had been deflected away from the detector (sincevandv_initwere then un-equal in length). I fixed this by removing deflected particles fromv_initas well in_coast_to_detector._adaptive_dtdepended on the velocity of the particlesv0, which was calculated increate_particlesbut not defined if the user provided particles inload_particles. Furthermore, user-provided particles don't necessarily have the same energy. I solved that by usingmax(v)in_adaptive_dt, which I'm calculating once at the beginning ofrun()._adaptive_dtnow calculates the cyclotron period using the provided particle charge and mass (previously assumed protons).I have added a changelog entry for this pull request.