Pull Request Test Coverage Report for Build 11980129171

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.492%

Totals
Change from base Build 11956491937:	0.0%
Covered Lines:	1376
Relevant Lines:	1490

💛 - Coveralls

deno 2.1.0 build currently failing for linux/aarch64; fix in research. https://github.com/pkgxdev/pantry/actions/runs/11946529159/job/33301044063

deno 2.1.0 build currently failing for linux/aarch64; fix in research. pkgxdev/pantry/actions/runs/11946529159/job/33301044063

Ops, got it.

I am also investigating another issue. I was expecting a much better startup time with Deno 2.1.0:

• perf(compile): code cache denoland/deno#26528 (comment)
• Deno compile code cache seems not working when error thrown during module loading denoland/deno#26976

Turns out Deno's 2.1.0 code caching is working indeed.

Something to be aware of is that running pkgx with Deno 2.1.0 will create files outside pkgx's cache directory, unless deno compile --no-code-cache.

# let's start clean
❯ deno clean
Removed /home/felipecrs/.cache/deno (7569 files, 86.04MB)

❯ ./pkgx-cc --sync

❯ deno clean
Removed /home/felipecrs/.cache/deno (4 files, 76.27KB)

EDIT: Correction:

Code cache will be written to /tmp/deno-compile-pkgx.cc. Whatever is being added to ~/.cache/deno is unrelated to code cache.

looks like the build worked for 2.1.1, so i'm guessing their changes fixed it.

Strictly ^2.0.2 will use 2.1.1 if available.

Hmm didn't mean to close this.

Maybe it would be a good idea to have full control over Deno's version. It would make the changelog easier and also improve reproducibility.

But anyway, whatever you prefer. What really matters is that the new Deno version is used.

@mxcl, slightly related, deno compile now has an --include flag to embed arbitrary files. Maybe it would be useful to embed the SQLite binary?