Fixed off-by-one error in checking length of abstract namespace Unix sockets #14483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use PHP to talk to Xdebug's new out-of-band control sockets, which use the abstract Unix domain socket namespace (socket names starting with a
\0
character).Xdebug uses names that are the maximum allowed length for these socket names (108 bytes).
However, when I tried to run:
I got the following output and error:
But the path is exactly 108 characters, not more. It turned out that the check for this maximum length is wrong.
No new test can easily be created, as the
108
is implementation specific, andext/standard/tests/streams/bug60106.phpt
already covers it.With this change, I can now correctly connection to these sockets.