-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: ability to let users to authenticate with a private oidc provider only #4882
Comments
I'm not sure, but maybe you could put the flag |
@thebaultyoann Thanks for a workaround. |
Check the API on the /api/doc endpoint of your penpot url. It exists a route to register people, so I guess yes, somebody can register anyway. But is that really an issue ? The only issue could be that someone managed through API requests to put himself into your penpot's team and export all the data you have. I didn't took the time to check, but I don't think Penpot team such a security breach open. |
It's not a problem to research endpoints, params, etc. in the code. When somebody registers in penpot, an email confirmation arrives to confirm the email address specified, if the person follows by the link he gets an access to the dashboard. |
Reverting 81b52d7 seems to restore the behavior of OIDC working with
I believe these flags should support basically all registration use-cases. |
I will look on it ASAP, and we trigger a patch release when it is fixed. |
Added the will be released on the next patch version. |
Hi @vladimirdulov, Thanks for reporting this! We've added this to our backlog on Taiga so that we can look further into it, you can find the details here: https://tree.taiga.io/project/penpot/issue/8477 |
This issue has been fixed and the fix will be release soon! |
Steps To Reproduce
Hello,
We are packaged
penpot
app forCloudron
(https://cloudron.io).Recently authentication seems to be changed in v2.1.0 and now we are facing with an issue that login via our Cloudron OIDC provider stopped to work until
enable-registration
flag is set.The configuration we'd like to have working:
But it causes
Registration is currently disabled
error if OIDC user authenticates first time.If we set
enable-registration
flag, authentication via OIDC starts to work but alsoCreate an account
link appears on the login form which doesn't have any sense in our case as we'd like users from Cloudron user directory to authenticate.maybe you can implement
enable-registration-with-oidc
flag to automatically create OIDC users or create respective users automatically w/o additional flag?Expected behavior
The configuration we'd like to have working:
maybe you can implement
enable-registration-with-oidc
flag to automatically create OIDC users or create respective users automatically w/o additional flag?Actual behavior
But it causes
Registration is currently disabled
error if OIDC user authenticates first time.If we set
enable-registration
flag, authentication via OIDC starts to work but alsoCreate an account
link appears on the login form which doesn't have any sense in our case as we'd like users from Cloudron user directory to authenticate.Screenshots or video
No response
Desktop (please complete the following information)
any browser
Smartphone (please complete the following information)
No response
Environment (please complete the following information)
https://www.cloudron.io/store/app.penpot.cloudronapp.html
Frontend Stack Trace
No response
Backend Stack Trace
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: