Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Selecting from Color Palette does not work for board when there is no existing fill #3941

Closed
rohannelson opened this issue Dec 27, 2023 · 4 comments · Fixed by #4020
Closed

bug: Selecting from Color Palette does not work for board when there is no existing fill #3941

rohannelson opened this issue Dec 27, 2023 · 4 comments · Fixed by #4020
Assignees
@Alotor
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Milestone
2.0.0

Comments

@rohannelson
Copy link

Steps To Reproduce

  1. Create a board
  2. Open color palette (if not open already)
  3. Try to select a color

Expected behavior

Selecting a color should create a fill of the selected color in the board.

Actual behavior

No color is selected. If a fill is manually created from the side panel, it is then possible to select colors using the color palette.
For rectangles and ellipses there is no need to create a fill manually first, partly because they start with a fill by default, but even if you delete the fill on a rectangle or ellipse selecting a color from the color palette still works. If boards worked like rectangles and ellipses it would remove one step from selecting the desired color for a board which would improve usability.

Screenshots or video

No response

Desktop (please complete the following information)

Windows 10, Firefox 121.0

Smartphone (please complete the following information)

No response

Environment (please complete the following information)

https://design.penpot.app

Frontend Stack Trace

No response

Backend Stack Trace

No response

Additional context

No response
@madalenapmelo-kp
Copy link
Contributor

Hi @rohannelson,

Thank you for reporting this! Just to make sure I understand the behavior you are describing, would you be able to share a screen recording?

@rohannelson
Copy link
Author

Sure thing, here it is -
PenPot Issue.zip
Hope it's clear.
By the way, I noticed after recording that demo that boards start with white fill when they are parent level, but if it is a board within a board then by default they start without a fill - this was what I was encountering on my project. Happy to send through another recording if that is helpful.

@madalenapmelo-kp
Copy link
Contributor

Hi @rohannelson,

Thanks for the video, all clear now! I have opened a Bug on Taiga so that we can look into fixing this, you can check the details here: https://tree.taiga.io/project/penpot/issue/6464

@madalenapmelo-kp madalenapmelo-kp added the managed on taiga This issue has been moved to our project at Taiga.io label Jan 4, 2024
@rohannelson
Copy link
Author

rohannelson commented Jan 4, 2024 via email

@Alotor Alotor self-assigned this Jan 15, 2024
@Alotor Alotor added this to the 1.20.0 milestone Jan 15, 2024
@Alotor Alotor linked a pull request Jan 16, 2024 that will close this issue
Alotor bugfixing 8 #4020
Merged
@Alotor Alotor closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alotor Alotor

Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Alotor bugfixing 8 penpot/penpot
3 participants
@Alotor @rohannelson @madalenapmelo-kp