dataset API fixes

patrickkunka · Dec 16, 2016 · 4be4087 · 4be4087
1 parent f6810b2
commit 4be4087
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,4 +13,9 @@ Change Log
 
 - Added `selectors.controls` configuration option to allow for further specificity of control querying
 in addition to the mandatory data attirbutes.
-- Fixed package.json issues
+- Fixed package.json issues.
+
+## 3.1.1
+
+- Fixed issue where `transitionend` event handlers were not rebound to re-rendered targets during dirtyCheck updates.
+- Fixed issue where dataset operation objects where created on push to queue, resulting in corrupted target data.
diff --git a/demos/mixitup.min.js b/demos/mixitup.min.js
diff --git a/dist/mixitup.js b/dist/mixitup.js
@@ -1,7 +1,7 @@
 /**!
- * MixItUp v3.1.0
+ * MixItUp v3.1.1
  * A high-performance, dependency-free library for animated filtering, sorting and more
- * Build d6e794dc-5811-4a4e-a2d9-fd3e620c147d
+ * Build 089145d5-822b-4610-879b-c9f0026e27a6
  *
  * @copyright Copyright 2014-2016 KunkaLabs Limited.
  * @author    KunkaLabs Limited.
@@ -7558,9 +7558,13 @@
 
                         target.data = data;
 
+                        target.unbindEvents();
+
                         self.dom.parent.replaceChild(el, target.dom.el);
 
                         target.dom.el = el;
+
+                        target.bindEvents();
                     }
 
                     el = target.dom.el;
@@ -8161,7 +8165,7 @@
         dataset: function() {
             var self        = this,
                 instruction = self.parseDatasetArgs(arguments),
-                operation   = self.getDataOperation(instruction.command.dataset),
+                operation   = null,
                 queueItem   = null,
                 animate     = false;
 
@@ -8172,6 +8176,8 @@
 
                 animate = (instruction.animate ^ self.config.animation.enable) ? instruction.animate : self.config.animation.enable;
 
+                operation = self.getDataOperation(instruction.command.dataset);
+
                 return self.goMix(animate, operation);
             } else {
                 queueItem = new mixitup.QueueItem();
@@ -10370,5 +10376,5 @@
         mixitup.registerJqPlugin(jq);
     }
     mixitup.NAME = 'mixitup';
-    mixitup.CORE_VERSION = '3.1.0';
+    mixitup.CORE_VERSION = '3.1.1';
 })(window);
diff --git a/dist/mixitup.min.js b/dist/mixitup.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "mixitup",
   "title": "MixItUp",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "A high-performance, dependency-free library for animated filtering, sorting and more",
   "author": "KunkaLabs Limited",
   "homepage": "https://www.kunkalabs.com/mixitup/",

diff --git a/src/mixer.js b/src/mixer.js
@@ -2698,9 +2698,13 @@ h.extend(mixitup.Mixer.prototype,
 
                     target.data = data;
 
+                    target.unbindEvents();
+
                     self.dom.parent.replaceChild(el, target.dom.el);
 
                     target.dom.el = el;
+
+                    target.bindEvents();
                 }
 
                 el = target.dom.el;
@@ -3301,7 +3305,7 @@ h.extend(mixitup.Mixer.prototype,
     dataset: function() {
         var self        = this,
             instruction = self.parseDatasetArgs(arguments),
-            operation   = self.getDataOperation(instruction.command.dataset),
+            operation   = null,
             queueItem   = null,
             animate     = false;
 
@@ -3312,6 +3316,8 @@ h.extend(mixitup.Mixer.prototype,
 
             animate = (instruction.animate ^ self.config.animation.enable) ? instruction.animate : self.config.animation.enable;
 
+            operation = self.getDataOperation(instruction.command.dataset);
+
             return self.goMix(animate, operation);
         } else {
             queueItem = new mixitup.QueueItem();