Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-serving documentation improvement suggestion #450

Open
chenguokai opened this issue Nov 30, 2024 · 0 comments
Open

Data-serving documentation improvement suggestion #450

chenguokai opened this issue Nov 30, 2024 · 0 comments

Comments

@chenguokai
Copy link

In the Data-serving benchmark document, the instruction for setting up the client is kind of vague:

Before running the measurement, you have to fill the server with the dataset. Use the script warmup.sh:

$ ./warmup.sh <server_ip> <record_count> <threads=1>

Users cannot determine the exact input format (whether we should specify the record_count in decimal or hex format, whether we should include threads= in the argument ). It can be improved by adding an example with default parameters specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant