Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] update compile_all_aircrafts test #933

Merged
merged 3 commits into from
Nov 8, 2014
Merged

Conversation

flixr
Copy link
Member

@flixr flixr commented Nov 7, 2014

Also replace LOCAL_CFLAGS (which wasn't used anymore) with USER_CFLAGS (and add where missing).
Now you can e.g. test compile all aircrafts/targets in your conf and add extra flags like treating warnings as errors:

J=AUTO USER_CFLAGS=-Werror prove conf/examples

flixr added 2 commits November 7, 2014 14:07
Also replace LOCAL_CFLAGS (which wasn't used anymore) with USER_CFLAGS (and add where missing).
Now you can e.g. test compile all aircrafts/targets in your conf and add extra flags like treating warnings as errors:

$ J=AUTO USER_CFLAGS=-Werror prove conf/examples
use prove instead of make run_tests so it will use all tests in tests/examples
(we can add more without changing config)
@flixr flixr force-pushed the tests_and_user_cflags branch from 2d10b20 to a21ea1e Compare November 7, 2014 14:08
@flixr
Copy link
Member Author

flixr commented Nov 7, 2014

@gautierhattenberger what do you think?
The only reference to LOCAL_CFLAGS I could find was some old avr stuff that we long since got rid off. Or is there any other reason to keep that?

generators should only output on stderr if there actually was an error.
Rather echo to stdout from the makefile to print the info.

This makes it possible to redirect stderr on compiling/testing to a buffer/file.
E.g. to check if there were warnings..
@flixr
Copy link
Member Author

flixr commented Nov 7, 2014

Also commented out the info that some generators printed to stderr.
They should only do that if there actually was an error.
Rather echo to stdout from the makefile to print the info.

This makes it possible to redirect stderr on compiling/testing to a buffer/file.
E.g. to check if there were warnings..

@gautierhattenberger
Copy link
Member

It is okay to replace LOCAL_CFLAGS by USER_CFLAGS.
The rest looks also good to me.

@flixr flixr merged commit 81aa9e9 into master Nov 8, 2014
@flixr flixr deleted the tests_and_user_cflags branch November 8, 2014 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants