Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with automatically configuring newer ublox modules #646

Merged
merged 2 commits into from
Feb 27, 2014

Conversation

achambers16
Copy link
Contributor

The current auto-configuration uses a "no longer supported" method to set the desired output messages from the ublox.
Currently, it sets the configuration for 4 outputs ports at once but starting with ublox 5, there are 6 I/O ports and this command no longer works.
See Section 4.5 "How to change between protocols" in GPS.G6-SW-10018-F
http://www.u-blox.com/images/downloads/Product_Docs/u-blox6_ReceiverDescriptionProtocolSpec_%28GPS.G6-SW-10018%29.pdf

This pull request sets the configuration of only 1 output port. That output port is determined by the port that receives the configuration message.

Fixes #645

@gautierhattenberger
Copy link
Member

If the old CFG_MSG message is not valid anymore (4 instead of 6 IO port), it should be removed or at least fixed.

@achambers16
Copy link
Contributor Author

I think we should remove the old CFG_MSG completely. It isn't used anywhere else in the project. I'll update the pull request with the changes.

@flixr
Copy link
Member

flixr commented Feb 27, 2014

What about the old ublox 4? I guess quite a few people still have/use some that work just fine...
If this module then only works from ublox 5 and up it should at least by very clearly stated in the description.

@achambers16
Copy link
Contributor Author

Switching to this CFG-MSG will provide better support across module generations. The suggested change works for ublox 4 through ublox 7 modules and will very likely work for modules in the future since we don't need to know how many input/output ports the future modules will have.

I had a bit of hard time finding the specification for ublox 4 modules. So here is a link if other people want it.
http://www.u-blox.com/en/distributor/993-antaris-4-gps-modules-resources.html

@flixr
Copy link
Member

flixr commented Feb 27, 2014

Great, thx @achambers16
Looks good to me (without actually having tested it).
@gautierhattenberger any more comments before we merge this?

@gautierhattenberger
Copy link
Member

good for me as well

@flixr
Copy link
Member

flixr commented Feb 27, 2014

Shame that we still need GPS_PORT_ID for UbxSend_CFG_PRT....

flixr added a commit that referenced this pull request Feb 27, 2014
Fix compatibility with automatically configuring newer ublox modules
@flixr flixr merged commit 3d30210 into paparazzi:master Feb 27, 2014
@achambers16 achambers16 deleted the ublx_center_compat branch February 28, 2014 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to configure u-blox NEO 6M with the gps_ubx_ucenter
3 participants