-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control modules #1978
Control modules #1978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, basically LGTM.
Shouldn't we already remove the "old" settings files and update all confs with the PR though?
Since otherwise people with their confs will have the settings added multiple times (or whatever happens in that case)?
<description> | ||
Adaptive attitude and lateral (heading) control for fixedwing aircraft. | ||
Mostly based on PID and optional reference generators and feedforward gains. | ||
Adaptive parameters should not be used for normal operation at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a kind of low pass filter to adapt the feedforward gains in flight. That's why it was called 'adaptive' in the first place. But it wasn't really working when I did this years ago and never touched it again...
I can remove the line if you think it is too much ambiguous.
I wasn't sure about removing the settings files as it will break personal confs as well. When keeping both, people will see new settings and that will "tell" them that they should update. We can remove them later before the release for instance. |
0487a7e
to
126cbe6
Compare
Convert control, guidance and navigation subsystems to modules.
In most cases, the proper documentation and settings are included in the modules.
Fixedwing, rotorcraft and test config are updated. Other conf files are still using the old settings files but since they are not deleted (yet), they can still be used.
Some parts were automatically included (guidance and nav for rotorcraft) so as a temporary hack, it is autoloaded from stabilization modules. This can be improved in the future with dependency and autopilot generation systems.