Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control modules #1978

Merged
merged 6 commits into from
Jan 10, 2017
Merged

Control modules #1978

merged 6 commits into from
Jan 10, 2017

Conversation

gautierhattenberger
Copy link
Member

Convert control, guidance and navigation subsystems to modules.

In most cases, the proper documentation and settings are included in the modules.
Fixedwing, rotorcraft and test config are updated. Other conf files are still using the old settings files but since they are not deleted (yet), they can still be used.

Some parts were automatically included (guidance and nav for rotorcraft) so as a temporary hack, it is autoloaded from stabilization modules. This can be improved in the future with dependency and autopilot generation systems.

Copy link
Member

@flixr flixr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, basically LGTM.

Shouldn't we already remove the "old" settings files and update all confs with the PR though?
Since otherwise people with their confs will have the settings added multiple times (or whatever happens in that case)?

<description>
Adaptive attitude and lateral (heading) control for fixedwing aircraft.
Mostly based on PID and optional reference generators and feedforward gains.
Adaptive parameters should not be used for normal operation at the moment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a kind of low pass filter to adapt the feedforward gains in flight. That's why it was called 'adaptive' in the first place. But it wasn't really working when I did this years ago and never touched it again...
I can remove the line if you think it is too much ambiguous.

@gautierhattenberger
Copy link
Member Author

I wasn't sure about removing the settings files as it will break personal confs as well. When keeping both, people will see new settings and that will "tell" them that they should update. We can remove them later before the release for instance.
I agree the other confs in the repo could be updated.

@flixr flixr merged commit 6434e01 into master Jan 10, 2017
@flixr flixr deleted the control_modules branch January 10, 2017 20:50
flixr added a commit that referenced this pull request Feb 5, 2017
make sure the autopilot implementation init which sets the STARTUP_MODE is called after the guidance module init has run.

This should fix a regression from #1977 and #1978
podhrmic pushed a commit that referenced this pull request Mar 7, 2017
make sure the autopilot implementation init which sets the STARTUP_MODE is called after the guidance module init has run.

This should fix a regression from #1977 and #1978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants