Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys mon fix #1846

Merged
merged 4 commits into from
Aug 22, 2016
Merged

Sys mon fix #1846

merged 4 commits into from
Aug 22, 2016

Conversation

podhrmic
Copy link
Member

Only one module (sys_mon) used - it will automatically detect if it is rtos, sim or bare-metal and will send the proper message (RTOS_MON or SYS_MON). Easier to use because the user don't have to change between sys_mon and rtos_mon anymore. Plus it works for SIM arch now.

@flixr
Copy link
Member

flixr commented Aug 19, 2016

Only drawback that I can see is that now you can't use the "old" sys_mon module on OS targets anymore. I think that it can still be useful to get an idea about the cycle times and jitter.
It would make sense to implement the rtos_mon (which is actually not restricted to RTOSs) for Linux targets as well, at least there the cycle times and jitter were sometimes useful.
@gautierhattenberger what do you think?

@podhrmic
Copy link
Member Author

I was thinking about actually merging those two together - so then you would have one struct that combines Sys_mon and Rtos_mon variables. But I didn't do it becase Rtos_mon takes much more memory and wouldnt be used on bare-metal, which might be a waste for old LPC boards.

Linux expansion is welcome, but probably people using ArDrones etc are better suited for the task.

@podhrmic
Copy link
Member Author

Btw I tested the old sys_mon on Lisa MX with ChibiOS and it just shows 100% CPU usage and the other indicators are constant, while the correct CPU usage from RTOS_MON is ~10%. So it is probably safe to say that people wont miss the old sys_mon for RTOS targets...

@flixr
Copy link
Member

flixr commented Aug 19, 2016

It worked fine on Linux targets... the jitter is sometimes really useful information...

@flixr
Copy link
Member

flixr commented Aug 19, 2016

by "worked fine" I actually mean that the timing info was working and useful, the cpu_load estimate not...
maybe we should try to add this for the rtos_mon as well?

But since rtos_mon is not implemented currently for linux, it is probably no reason to not merge this...

@podhrmic
Copy link
Member Author

this will still run the "regular" sys_mon for linux targets, only Chibios (and nps) uses rtos_mon - so you can use it as before

@podhrmic
Copy link
Member Author

@@ -1,7 +1,7 @@
/*
* Copyright (C) 2016 Gautier Hattenberger <[email protected]>
* Copyright (C) 2010 Gautier Hattenberger

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous license header looked more correct.

@flixr flixr merged commit 41b2e7e into master Aug 22, 2016
@flixr flixr deleted the sys_mon_fix branch August 22, 2016 21:48
@flixr flixr added the Module label Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants