-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sys mon fix #1846
Sys mon fix #1846
Conversation
Only drawback that I can see is that now you can't use the "old" sys_mon module on OS targets anymore. I think that it can still be useful to get an idea about the cycle times and jitter. |
I was thinking about actually merging those two together - so then you would have one struct that combines Linux expansion is welcome, but probably people using ArDrones etc are better suited for the task. |
Btw I tested the old sys_mon on Lisa MX with ChibiOS and it just shows 100% CPU usage and the other indicators are constant, while the correct CPU usage from RTOS_MON is ~10%. So it is probably safe to say that people wont miss the old sys_mon for RTOS targets... |
It worked fine on Linux targets... the jitter is sometimes really useful information... |
by "worked fine" I actually mean that the timing info was working and useful, the cpu_load estimate not... But since rtos_mon is not implemented currently for linux, it is probably no reason to not merge this... |
this will still run the "regular" sys_mon for linux targets, only Chibios (and nps) uses rtos_mon - so you can use it as before |
@@ -1,7 +1,7 @@ | |||
/* | |||
* Copyright (C) 2016 Gautier Hattenberger <[email protected]> | |||
* Copyright (C) 2010 Gautier Hattenberger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous license header looked more correct.
Only one module (sys_mon) used - it will automatically detect if it is rtos, sim or bare-metal and will send the proper message (RTOS_MON or SYS_MON). Easier to use because the user don't have to change between sys_mon and rtos_mon anymore. Plus it works for SIM arch now.