Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pprzlink] update to C API with file descriptor param #1593

Merged
merged 5 commits into from
Apr 12, 2016
Merged

[pprzlink] update to C API with file descriptor param #1593

merged 5 commits into from
Apr 12, 2016

Conversation

flixr
Copy link
Member

@flixr flixr commented Apr 2, 2016

This was already once proposed and mergd with #1589 (and reverted again) since with these changes the simulators don't work anymore.
So this needs some more work and checking before it can be integrated again.

flixr added 3 commits April 2, 2016 11:40
@flixr
[pprzlink] update to C API with file descriptor param
b8c7718 
This was already once proposed and mergd with #1589 (and reverted again) since with these changes the simulators don't work anymore.
So this needs some more work and checking before it can be integrated again.
@flixr
[udp] fix put_buffer for UDP devices
e61d336 
udp_send_raw doesn't add to the "normal" transmit buffer, but rather directly send the whole buffer passed to it.
But put_buffer is supposted to multiple bytes to the current transmit buffer where a message is being assembled,
so actually do that in a udp_put_buffer function.
@flixr
[pprzlink] fix ivy_transport
f00dbbe
@flixr
Copy link
Member Author

flixr commented Apr 2, 2016

Ok, I think I found and fixed the remaining bugs, OCaml sim and NPS are working again.
But please double check...

@gautierhattenberger
Copy link
Member

Tested and working with:

  • ocaml sim
  • nps rotorcraft
  • nps fixedwing
  • elle0 with pprz_transport
  • ardrone2 (udp, pprz)
  • apogee with xbee_transport (with bug fix)
  • SD logging on apogee (with bug fix)

@flixr
Copy link
Member Author

flixr commented Apr 4, 2016

Thx.
So I guess still untested are the following datalinks:

  • bluegiga
  • w5100
  • spektrum

@kirkscheper could you test bluegiga?
@gtoonstra could you test w5100?

@gautierhattenberger
Copy link
Member

@flixr since all transports have have been tested (and fixed) and most common devices as well, is it possible to merge this again ?
It seems that Delft team is really busy with outback challenge so they probably won't have time to test bluegiga and superbitrf (@esden ?).
Also modifications on devices where lighter than transports and I checked them again.
It is not like it is urgent for paparazzi/master, but it will make pprzlink pull requests and update easier since fd parameter is already in master branch there (okay this was too early as well).

@flixr flixr merged commit 1741203 into master Apr 12, 2016
@flixr flixr added this to the v6.0 milestone Apr 12, 2016
@flixr flixr deleted the pprzlink_file_descriptor branch April 12, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@flixr @gautierhattenberger