New asctec ESC i2c protocol #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it is needed or desirable, but if we add the new protocol in separate files/subsystem it will be possible to use both old and new versions of the controllers at the same time... |
|
I would vote for seperate files/subsystem. Not sure about the naming of it. Small fix in the code: at switch case 4 of set_addres the variable set_address should be set to 0 again. This fixes the problem of needing to reboot the drone to set each address. |
|
Seems ok for me to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i2c protocol to communicate with asctec escs has changed. The escs are still called v2, so I am not sure if I should make an actuators_asctec_v2_new.c file with another settings file, or make a define that switches between protocols within the actuators_asctec_v2.c file. What is preferred?