Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[module] read in and decode stereo camera messages #1317

Closed
wants to merge 8 commits into from

Conversation

kirkscheper
Copy link
Member

Added a module to read in and decode messages from a stereo camera using a UART connection. Module is in sw/airborne/modules/sensors.

Please let me know if I need to move, change update anything.

@kirkscheper
Copy link
Member Author

Idea... I can also make the baud rate configurable in the airframe file. Might be useful considering the issues with the previous attempt to push to master.

@gautierhattenberger
Copy link
Member

that is indeed a good idea to be able to set both port and baudrate

@flixr
Copy link
Member

flixr commented Aug 28, 2015

Would also make sense to not "hardcode" SEND_STEREO to true in the makefile...
Better define it to TRUE by default in the .c file and check it with #if SEND_STEREO
Or even better make it a flag that you can change at runtime...

Also please add the configure and define options to the documentation section in the module xml.

@flixr flixr added the Module label Aug 28, 2015
@flixr
Copy link
Member

flixr commented Aug 28, 2015

And probably most importantly: what kind of "stereocam" is this module for??

@kirkscheper
Copy link
Member Author

The stereocam here is a custom design by Christophe de Wagter that is extensively used at the TU Delft. We have a couple of people working on this camera now in paparazzi, that's why I am trying to push this module now.

@flixr
Copy link
Member

flixr commented Aug 31, 2015

Thx!
Would be really nice if you could document the configure and define options with their respective xml tags in the module xml.
That way they are properly used in the generated documentation.... (see e.g. the digital cam module):

*
*/

/** @file modules/stereocam.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path incorrect...

@flixr
Copy link
Member

flixr commented Sep 2, 2015

Thx! Merged with 4ac38c7 and d463e02

@flixr flixr closed this in d463e02 Sep 2, 2015
@flixr flixr added this to the v5.8 milestone Sep 2, 2015
@kirkscheper kirkscheper deleted the stereocam_module branch September 11, 2015 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants