Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rotorcraft] fix arming with kill switch #1125

Merged
merged 2 commits into from
Jul 7, 2015
Merged

Conversation

flixr
Copy link
Member

@flixr flixr commented Mar 2, 2015

Untested, but should fix #1041

@flixr
Copy link
Member Author

flixr commented Mar 2, 2015

@dewagter can you please test if this solves the problem and you get the behaviour you expect?

@OpenUAS OpenUAS self-assigned this Apr 23, 2015
@OpenUAS
Copy link
Contributor

OpenUAS commented Apr 23, 2015

Weather permitting tests performed in weekends of 201505

@flixr flixr added this to the v5.6 milestone Jun 8, 2015
@flixr flixr force-pushed the fix_kill_switch_arming branch from 6e8cb36 to 54af08a Compare June 29, 2015 22:03
@flixr
Copy link
Member Author

flixr commented Jun 29, 2015

@dewagter What kind of behaviour do we want in the case when it goes to FAILSAFE but does't KILL on landing (e.g. because you haven't enabled that)?
The currently proposed fix allow immediate rearming from FAILSAFE, should we also prevent it that case?

@dewagter
Copy link
Member

If the condition that triggered the failsafe is still present, then it
should remain failsafe, otherwise immediate rearming is acceptable.

-Christophe

On Tue, Jun 30, 2015 at 12:11 AM, Felix Ruess [email protected]
wrote:

@dewagter https://github.com/dewagter What kind of behaviour do we want
in the case when it goes to FAILSAFE but does't KILL on landing (e.g.
because you haven't enabled that)?
The currently proposed fix allow immediate rearming from FAILSAFE, should
we also prevent it that case?


Reply to this email directly or view it on GitHub
#1125 (comment).

@flixr
Copy link
Member Author

flixr commented Jun 30, 2015

Checking which condition triggered failsafe would be a pain, but if the problem doesn't exist anymore (e.g. GPS lost), then the quad should go into the mode as set on the RC again...
So I added a check for the FAILSAFE mode.

flixr added a commit that referenced this pull request Jul 7, 2015
[rotorcraft] fix arming with kill switch

fixes #1041
@flixr flixr merged commit 29656c6 into master Jul 7, 2015
@flixr flixr deleted the fix_kill_switch_arming branch July 7, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kill_switch_arming not perfect yet:
3 participants