Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rotorcraft] fix attitude_set_rpy_setpoint #1103

Merged
merged 1 commit into from
Feb 27, 2015

Conversation

flixr
Copy link
Member

@flixr flixr commented Feb 13, 2015

Use quat_of_eulers instead of quat_from_rpy_cmd to match what users expect from attitude_set_rpy_setpoint.
Specifically actually make the attitude primitive in the flight plan work as expected.

@flixr
Copy link
Member Author

flixr commented Feb 13, 2015

@dewagter @fvantienen is the current ardrone2_opticflow_hover.xml airframe working properly?
Since the opticflow hover module also uses attitude_set_rpy_setpoint, I strongly suspect that it doesn't work properly without this fix...
Or am I missing something?

@EwoudSmeur
Copy link
Member

Shouldn't the function now be renamed to stabilization_attitude_set_euler_setpoint_i?
What happens when the command is not a correct euler combination, e.g. pitch > 90 degrees?

@flixr
Copy link
Member Author

flixr commented Feb 16, 2015

I didn't want to rename the function to to euler, because it wasn't supposed to take "real" euler angles as input.
But calling quat_of_eulers instead of quat_from_rpy_cmd at least works for the normal cases.
Properly fixed quat_from_rpy_cmd would be appreciated ;-)

@flixr
Copy link
Member Author

flixr commented Feb 19, 2015

@dewagter @OpenUAS @gautierhattenberger (or anyone who can test the ardrone2_opticflow_hover) do you have any feedback here?

use quat_of_eulers instead of quat_from_rpy_cmd to match what users expect from attitude_set_rpy_setpoint
@flixr flixr force-pushed the fix_attitude_set_rpy_setpoint branch from a9a2a43 to 8634b72 Compare February 27, 2015 14:00
@flixr
Copy link
Member Author

flixr commented Feb 27, 2015

Feedback timeout: merging into master as this clearly fixes usage of the attitude flight plan primitive and except from the ardrone2 opticflow hover doesn't seem to be used anywhere else.
I guess we should backport this for v5.4 as well...

@flixr flixr merged commit 8634b72 into master Feb 27, 2015
@flixr flixr deleted the fix_attitude_set_rpy_setpoint branch February 27, 2015 14:36
Fab7c4 pushed a commit to Fab7c4/paparazzi that referenced this pull request May 24, 2015
Paparazzi 5.4.2_stable
======================

Maintenance release

- GCS: fix undo for list of values
  [paparazzi#1054] (paparazzi#1054)
- lisa_mx: fix secondary spektrum satellite UART AF
- logalizer: fix csv export after allowing description tag in messages
- nps: update nps_fdm_jsbsim to be compatible with latest jsbsim
  [paparazzi#1118] (paparazzi#1118)
- rotorcraft: fix attitude flight plan primitive
  [paparazzi#1103] (paparazzi#1103)
- flight plans: fix 'call' statement without loop
- generators: only include raw makefile part from modules if target matches
- GCS: GPS accuracy speech less verbose
  [paparazzi#1046] (paparazzi#1046)
- GCS: call index of first/single link "single"
  [paparazzi#1098] (paparazzi#1098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants