Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select_conf] Now also selects control_panel #1001

Closed
wants to merge 1 commit into from

Conversation

dewagter
Copy link
Member

@dewagter dewagter commented Dec 1, 2014

Finally you can now also commit you own control_panel.xml and switch between versions.

  • Several bugfixes and implemented todo's
  • Although more buttons are added, design reviewed to be lighter

@flixr
Copy link
Member

flixr commented Dec 2, 2014

Nice, looks good to me (except that I would probably put the "show backups" checkbox above the activate,launch,exit button row)...

@dewagter dewagter force-pushed the select_controlpanel branch from f1f2e71 to 6fc3a9f Compare December 2, 2014 10:25
@dewagter
Copy link
Member Author

dewagter commented Dec 2, 2014

merged with c6ee0f2

backported (as it solves several bugs) with 4217ca7

@dewagter dewagter closed this Dec 2, 2014
@flixr flixr deleted the select_controlpanel branch December 2, 2014 11:50
@flixr
Copy link
Member

flixr commented Dec 2, 2014

Thx, but wondering which bugs you are referring to...

@dewagter
Copy link
Member Author

dewagter commented Dec 2, 2014

  • not all menu options were working
  • if a conf.xml did not exist, it crashed
  • it did not ask confirmation on deleting files
  • it did not make a backup in certain cases

@bartremes had a good proposition: we should maybe call it start.py
instead of select_conf.py

@flixr
Copy link
Member

flixr commented Dec 2, 2014

Ok.
Regarding the naming of the script, I'm not convinced start.py is really a better name as you don't need to use it (e.g. I personally only use it to switch to a different conf, but otherwise start paparzzi as usual)... but I have no strong opinion on this...

@flixr
Copy link
Member

flixr commented Dec 2, 2014

Thinking about an installable paparazzi version, maybe we should rename it to pprz-launch or paparazzi-launch that can be added to the PATH...? (and possibly add a symlink select_conf.py for people who are used to that)

@dewagter
Copy link
Member Author

dewagter commented Dec 3, 2014

what about setup ?

-Christophe

On Tue, Dec 2, 2014 at 9:17 PM, Felix Ruess [email protected]
wrote:

Thinking about an installable paparazzi version, maybe we should rename it
to pprz-launch or paparazzi-launch that can be added to the PATH...? (and
possibly add a symlink select_conf.py for people who are used to that)


Reply to this email directly or view it on GitHub
#1001 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants