-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strings Deprecated Warning for Ocaml ≥ 4.02 #1703
Comments
We could also use |
Is this an ok way to fix the makefile? EDIT: probably not. I need to make sure that compat.ml compiles first. Ill work on it a bit more. |
Ok so I think I fixed the Makefile. I used a shell if statement to only compile files listed in PP_SRC with the preprocessor. rijesha@81f9dfb I started to modify the rest of the .ml files. PPRZLINK will need to be modified. It compiles first so compat.ml will have to be copied into that repo as well and the Makefile will need to be set up for the campl4. Unless there is a better way of doing it? |
Thanks for the work @rijeshaugustine ! |
For pprzlink just adding the compat module to it will cause another warning when building sw/lib/ocaml due to compat.cmo already existing. Can this be rectified by telling the sw/lib/ocaml/Makefile to ignore compat.ml if compat.cmo exits in sw/ext/pprzlink/*/ocaml/ or will that cause other issues in the future? |
Just an idea - can we update the ocaml version that is installed with paparazzi (i.e. package update)? That way we wouldn't have to worry about the backward compatibility (<4.02) I suppose? (I am assuming that even older OS like Ubuntu 12.04 can upgrade to the >4.02 Ocaml) |
@podhrmic that would be only possible if you manually install a newer OCaml version (from source or via opam)... |
What I did for the |
made a pull request for pprzlink paparazzi/pprzlink#23 |
Thanks! closing this as the relevant pull requests have been merged... |
As of Ocaml v4.02 Strings have been deprecated in favour of Bytes.
https://ocaml.org/releases/4.02.html
This results in a build warning when compiling Paparazzi.
Changing Strings to Bytes is not sufficient to silence the warnings, as it would break compilation for everyone with OCaml < 4.02.0
@flixr was looing into using the camlp4 preprocessor to IFDEF around this issue... flixr@007deab
The text was updated successfully, but these errors were encountered: