Add prefix filter to sstable2json #586
Conversation
| } else { | ||
| entry = sstable.getPosition(lastKey, SSTableReader.Operator.GT); | ||
| } |
There was a problem hiding this comment.
won't this keep researching the sstable every key instead of scanning forward from the first ?
There was a problem hiding this comment.
i think there's two pieces at play here: sstable.getPosition will have to binary search for the index for each key but dfile.seek will only ever move forward from the previous seeked position. this means searching for a prefix that has 100 keys is the same as if you searched speciically for those 100 keys with -k
There was a problem hiding this comment.
If you had a "next prefix" supplied I think you would be able to run this like a normal range scan right? like "prefix1" is the left bound then "prefix2" is the next?
There was a problem hiding this comment.
i think with the update this
this means searching for a prefix that has 100 keys is the same as if you searched speciically for those 100 keys with
-k
is still the case
RowIndexEntry entry = sstable.getPosition(decoratedKey, keysCount == 0 ? SSTableReader.Operator.GE : SSTableReader.Operator.GT);
i think like @zpear said we can just use the on disk atom iterator until we hit untilPrefix (or until the prefix doesn't match anymore) instead of researching for every key
|
manual testing |
|
talked offline — keeping the current implementation because
we want |
Enables finding all keys with a prefix within an sstable through sstable2json.