Nodetool Drain throws immediately if the server is not initialized #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpear
reviewed
Nov 21, 2024
Comment on lines
4615
to
4618
| else | ||
| { | ||
| throw new IllegalStateException("Cannot drain a node that is bootstrapping"); | ||
| } |
There was a problem hiding this comment.
this would happen if we called drain during regular startup as well, not just bootstrapping right
There was a problem hiding this comment.
then there's a question: if we're starting up vs bootstrapping is it desirable to wait for startup to complete then drain, or just fail the drain and continue w/ other shutdown actions later?
There was a problem hiding this comment.
The only case we should expect Drain to be called when the server is not fully initialized is if someone is taking manual action to terminate a node that is stuck initializing, or taking manual action to abort an in-progress bootstrap or node replacement. These are probably both cases we'd want to terminate without delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the drain method is
synchronized, calls tonodetool drainwill hang if the server is not initialized. This includes nodes that are bootstrapping.This PR makes these calls to
drain()fail fast, so the behavior is more obvious.