Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Symfony 3.0 upgrade #345

Closed
wants to merge 5 commits into from

Conversation

umpirsky
Copy link

I am testing Symfony Upgrade Fixer against several Symfony projects.

Will continue pushing commits to this PR, I hope you will find them useful.

@DimaSoroka
Copy link
Contributor

Thanks @umpirsky, we'll get to it later next year. Our next upgrade will be Symfony 2.8.

@umpirsky
Copy link
Author

@DimaSoroka Sure, just testing the tool, thanks. ;)

@sagikazarmark
Copy link
Contributor

@DimaSoroka For when is the 2.8 upgrade is scheduled? WIth the upcoming update #341 becomes invalid.

@DimaSoroka
Copy link
Contributor

2.8 scheduled for Q1-Q2 next year

@sagikazarmark
Copy link
Contributor

Do you think it' possible to merge the mentioned PR prior to that?

@DimaSoroka
Copy link
Contributor

Yes, we'll include it in the release in January

@orocla
Copy link

orocla commented Dec 22, 2015

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for about an hour for the submission to be processed.

@orocla orocla added the cla: no label Dec 22, 2015
@umpirsky
Copy link
Author

@orocla Signed, thanks.

@orocla orocla added cla: yes and removed cla: no labels Dec 23, 2015
@Koc
Copy link

Koc commented Sep 9, 2016

@umpirsky maybe this PR should be rebased and run tool again with disabling use reorder?

@umpirsky
Copy link
Author

umpirsky commented Sep 9, 2016

Yes, will do...

@mkudelya
Copy link
Contributor

mkudelya commented Feb 8, 2017

Hi @umpirsky

We are planning migrate to Symfony3 at the end of this year after 3.4 release. Do you have any plans on this PR ?

@umpirsky
Copy link
Author

umpirsky commented Feb 8, 2017

@mkudelya We can close it, run Symfony-Upgrade-Fixer on latest code, and open new PR.

@mkudelya
Copy link
Contributor

@umpirsky

We will do that, thanks!

@mkudelya mkudelya closed this Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants