-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Symfony 3.0 upgrade #345
Conversation
Thanks @umpirsky, we'll get to it later next year. Our next upgrade will be Symfony 2.8. |
@DimaSoroka Sure, just testing the tool, thanks. ;) |
…efix() and reorder use statements
@DimaSoroka For when is the 2.8 upgrade is scheduled? WIth the upcoming update #341 becomes invalid. |
2.8 scheduled for Q1-Q2 next year |
Do you think it' possible to merge the mentioned PR prior to that? |
Yes, we'll include it in the release in January |
Thank you for your pull request. It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/ If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits. Once you've signed the CLA, please allow for about an hour for the submission to be processed. |
@orocla Signed, thanks. |
@umpirsky maybe this PR should be rebased and run tool again with disabling use reorder? |
Yes, will do... |
Hi @umpirsky We are planning migrate to Symfony3 at the end of this year after 3.4 release. Do you have any plans on this PR ? |
@mkudelya We can close it, run Symfony-Upgrade-Fixer on latest code, and open new PR. |
We will do that, thanks! |
I am testing Symfony Upgrade Fixer against several Symfony projects.
Will continue pushing commits to this PR, I hope you will find them useful.