Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Audit passwords and bind_key usage for proper quoting #348

Open
sdodson opened this issue Nov 12, 2014 · 1 comment
Open

Audit passwords and bind_key usage for proper quoting #348

sdodson opened this issue Nov 12, 2014 · 1 comment
Labels
enhancement

Comments

@sdodson
Copy link
Member

sdodson commented Nov 12, 2014

In README.asciidoc we say

NOTE: Passwords used to secure various services. You are advised to specify
only alphanumeric values in this script as others may cause syntax
errors depending on context. If non-alphanumeric values are required,
update them separately after installation.

We should audit all situations where we deal with passwords and other strings which may contain special characters to ensure safety rather than suggesting users avoid special characters.
@sdodson sdodson mentioned this issue Nov 12, 2014
Merged
@detiber
Copy link

detiber commented Nov 12, 2014

+1, I suspect the issue is where we are using those passwords in templated scripts (mongo configuration, register_dns, etc) as opposed to places we are just setting the passwords directly in the templated config files.

It is possible that we are failing to properly quote in some of ini style configs as well though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdodson @detiber